Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue template with more requested detail #4865

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update issue template with more requested detail #4865

merged 2 commits into from
Jan 30, 2024

Conversation

lrapoport-cf
Copy link
Contributor

Fixes N/A.

What this PR solves / how to test: Adds more detail to the issue template.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: just changing issue template
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: just changing issue template
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: just changing issue template

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@lrapoport-cf lrapoport-cf requested a review from a team as a code owner January 29, 2024 21:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b9b341

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7705805025/npm-package-wrangler-4865

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4865/npm-package-wrangler-4865

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7705805025/npm-package-wrangler-4865 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7705805025/npm-package-create-cloudflare-4865 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7705805025/npm-package-miniflare-4865
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7705805025/npm-package-cloudflare-pages-shared-4865

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.25.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.4
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbd2a4c) 70.70% compared to head (1b9b341) 70.74%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4865      +/-   ##
==========================================
+ Coverage   70.70%   70.74%   +0.04%     
==========================================
  Files         291      291              
  Lines       15164    15164              
  Branches     3859     3859              
==========================================
+ Hits        10721    10728       +7     
+ Misses       4443     4436       -7

see 6 files with indirect coverage changes

@lrapoport-cf lrapoport-cf merged commit 8ad218a into main Jan 30, 2024
17 checks passed
@lrapoport-cf lrapoport-cf deleted the lrapoport/update-issue-template branch January 30, 2024 03:40
@lrapoport-cf lrapoport-cf mentioned this pull request Jan 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrapoport-cf @petebacondarwin